I just tested on my existing site and it seems like the fits generation issue is only happening with the dev site. On my production site it is generating FITS correctly.

I tried making these changes to my dev site's docker-compose.yml and it still isn't generating FITS on Buildkit 3.2.7 or 3.4.0.

@joecorall Were you testing on a fresh dev install? It seems strange that this fixed it for you but not for me.

@joshdentremont - are the old/orphaned containers gone after making the change?

docker compose --profile dev up -d --remove-orphans

That didn't seem to make a difference. Still getting this error:

scholar-crayfits-dev-1  | [2024-08-15 13:57:11] request.CRITICAL: Uncaught PHP Exception ErrorException: "Warning: Undefined variable $response" at /var/www/crayfish/CrayFits/src/Controller/FitsController.php line 62 {"exception":"[object] (ErrorException(code: 0): Warning: Undefined variable $response at /var/www/crayfish/CrayFits/src/Controller/FitsController.php:62)"} []

Looks like this is a similar issue to this: roblib/CrayFits#13, but a different error message.

@joshdentremont - that's the error I was getting but switching to profiles in this PR fixed it.

Are you running on a Mac? I've had better success running linux images than arm

export DOCKER_DEFAULT_PLATFORM=linux/amd64
docker compose --profile dev pull
docker compose --profile dev up -d --remove-orphans

Perhaps it's the arm vs amd issue that's really at play here on Mac, but I think we should standardize all our services to use dev/prod profiles (fits/crayfits are the only two that don't) so whether this fixes the issue locally or not I think we should merge this.

Looks like this is a similar issue to this: roblib/CrayFits#13, but a different error message.

Your error message is the same. Rosie confirmed this PR addresses the known issue: roblib/CrayFits#13 (comment)

I just confirmed that this does fix it on a new install, so there is probably something else in my dev setup that is causing it not to work.

I also confirmed that this change does not break my fits generation in production.

I think this is fine to merge.

Thanks. I'm going to merge this since new installs are in a broken state without this PR.